Repository navigation
fix(tlsx): reject unsupported scan modes in New - #1035
Merged
dwisiswant0 merged 1 commit intoNov 4, 2026
Merged
Conversation
New sent every ScanMode its switch did not match to the branch meant for the empty default, so a typo or the wrong case such as "ZTLS" silently ran the ctls client and rewrote ScanMode to "ctls". Only the empty value keeps that default now; any value other than ctls, ztls, openssl or auto makes New return an error. Fixes: #1034 Signed-off-by: Dwi Siswanto <git@dw1.io>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Mzack9999
approved these changes
Nov 4, 2026
dwisiswant0
deleted the
dwisiswant0/fix/tlsx/reject-unsupported-scan-modes-in-new
branch
November 4, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New sent every ScanMode its switch did not match to the branch meant
for the empty default, so a typo or the wrong case such as "ZTLS"
silently ran the ctls client and rewrote ScanMode to "ctls". Only the
empty value keeps that default now; any value other than ctls, ztls,
openssl or auto makes New return an error.
Fixes: #1034